This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa8262a383bc6: [clang][darwin] add support for Mac Catalyst
availability (authored by arphaman).
Herald added a project: clang.
Repository:
rG
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105052/new/
https://reviews.llvm.org/D105052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman updated this revision to Diff 358457.
arphaman added a comment.
Sorry, took a bit longer than anticipated. I updated the patch to address
reviewer's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105052/new/
https://reviews.llvm.org/D105052
Files:
arphaman added a comment.
Thanks for the feedback, I'll update this patch tomorrow.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105052/new/
https://reviews.llvm.org/D105052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
Btw, the CI failures look to be unrelated to the patch. (It's pretty
unfortunate how often this is the case lately...)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105052/new/
https://reviews.llvm.org/D105052
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:860
+ .Case("maccatalyst", "macCatalyst")
+ .Case("maccatalyst_app_extension", "macCatalyst App Extension")
.Case("swift", "Swift")
Should
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, but since this hasn't been up for long maybe leave it open for a bit in
case someone else has a comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105052/new/
arphaman created this revision.
arphaman added reviewers: dexonsmith, dcoughlin, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a reviewer: aaron.ballman.
arphaman requested review of this revision.
This patch adds support for Mac Catalyst availability attribute, as supported
by
