[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Thanks for the fix :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. In D105112#2858702 , @thakis wrote: > Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's > VERSION_MAJOR after adding a LangOption, else builds with > LLVM_APPEND_VC_REV=NO won't invalidate their module

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's VERSION_MAJOR after adding a LangOption, else builds with LLVM_APPEND_VC_REV=NO won't invalidate their module cache correctly. See e.g. https://reviews.llvm.org/rGb8b7a9dcdcbc Without that, tests are

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9964b0ef828b: [clang] Add -fdump-record-layouts-canonical option (authored by daltenty, committed by stevewan). Repository: rG LLVM Github

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty added a comment. In D105112#2850990 , @stevewan wrote: > I'm not familiar with `getCanonicalType()`, can you confirm whether it sees > through nested typedef's? Add a test case that hopefully will cover the case you intend Repository: rG

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty updated this revision to Diff 355741. daltenty added a comment. - Update test case with nested typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 Files:

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. I'm not familiar with `getCanonicalType()`, can you confirm whether it sees through nested typedef's? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty created this revision. daltenty added reviewers: stevewan, dexonsmith. Herald added a subscriber: dang. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option implies -fdump-record-layouts but dumps record layout