[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. Thank you @martong. I'll load it ASAP. It's great to see symcasts is closer. Shame on me :) I'm mixed up in my own patches. I forgot that I separated them consciously for this purpose. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105340/new/

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

martong added a comment. In D105340#3237430 , @ASDenysPetrov wrote: > In D105340#3232671 , @NoQ wrote: > >> This looks great with the option flag. Landing this patch will enable more >> people to test the new

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. In D105340#3232671 , @NoQ wrote: > This looks great with the option flag. Landing this patch will enable more > people to test the new mode and produce feedback on whether the constraint > solver keeps working well enough

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks great with the option flag. Landing this patch will enable more people to test the new mode and produce feedback on whether the constraint solver keeps working well enough in presence of

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. Just a ping. I'd like to have this patch stack loaded somewhen :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105340/new/ https://reviews.llvm.org/D105340 ___ cfe-commits mailing list

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 374270. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105340/new/ https://reviews.llvm.org/D105340 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. In D105340#2855387 , @vsavchenko wrote: > Also, although the test is very extensive, it is pretty lopsided at the same > time. C-style cast is only one case out of the myriad of all explicit and, > more importantly,

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:318 +ANALYZER_OPTION(bool, ShouldHandleIntegralCastForRanges, +"handle-integral-cast-for-ranges", +"Handle truncations, promotions and

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added a comment. Also, even though the test is very extensive it is pretty lopsided at the same time. C-style cast is only one case out of the myriad of all explicit and, more importantly, implicit casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105340/new/

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/produce-symbolcast.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -analyzer-config handle-integral-cast-for-ranges=true -verify %s + steakhal wrote: > vsavchenko

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

steakhal added inline comments. Comment at: clang/test/Analysis/produce-symbolcast.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -analyzer-config handle-integral-cast-for-ranges=true -verify %s + vsavchenko wrote: > ASDenysPetrov

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added inline comments. Comment at: clang/test/Analysis/produce-symbolcast.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -analyzer-config handle-integral-cast-for-ranges=true -verify %s + ASDenysPetrov wrote: > vsavchenko

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. I will update the patch soon according to your suggestions. Comment at: clang/test/Analysis/bool-assignment.c:46-50 #ifdef ANALYZER_CM_Z3 BOOL x = y; // expected-warning {{Assignment of a non-Boolean value}} #else -BOOL x = y; //

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added inline comments. Comment at: clang/test/Analysis/range_casts.c:125-126 if (index - 1UL == 0L) // Was not reached prior fix. -clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}} +// Tempopary regression in scope of implementing integral

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added a comment. Hey, thanks for starting on splitting into more pieces! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:96 QualType OriginalTy); + SVal simplifySymbolCast(nonloc::SymbolVal V, QualType