[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d38ad0bc25: [clang][Analyzer] Add symbol uninterestingness to bug report. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske updated this revision to Diff 358545. balazske added a comment. Rename of DiagnosticVerifyConsumer. Changes related to handling of metadata symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2260-2261 + InterestingSymbols.erase(sym); + if (const auto *meta = dyn_cast(sym)) +markNotInteresting(meta->getRegion()); +} balazske wrote: > balazske wrote: > > NoQ

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2260-2261 + InterestingSymbols.erase(sym); + if (const auto *meta = dyn_cast(sym)) +markNotInteresting(meta->getRegion()); +} NoQ wrote: > You're saying, e.g., "If

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. Looks great, thanks for reusing the reusables! Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2260-2261 + InterestingSymbols.erase(sym); + if (const auto *meta = dyn_cast(sym)) +markNotInteresting(meta->getRegion()); +}

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske updated this revision to Diff 357873. balazske added a comment. Removed "garbage" from end of test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637 Files:

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske updated this revision to Diff 357872. balazske added a comment. Herald added a subscriber: mgorny. Added the unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637 Files:

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. In D105637#2867602 , @NoQ wrote: > You could define your own diagnostic consumer in the unittest and intercept > all the notes. (you can find an example of this in D94476 ) (I can't believe I

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. In D105637#2864684 , @balazske wrote: > Could not make a simple test for the change. This file F17831281: > BugReportInterestingnessTest.cpp is what > I could do, but it prints the needed text

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske added reviewers: martong, NoQ. balazske added a comment. Herald added a subscriber: rnkovacs. The original change D104300 contained these modifications but is currently not committed. The "uninterestingness" is really a separate patch that belongs to

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske added a comment. Could not make a simple test for the change. This file F17831281: BugReportInterestingnessTest.cpp is what I could do, but it prints the needed text to the console. Is it possible to get the note texts in the program? Repository:

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of this