[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the reviews, everyone. I've commit in de59f564400de1b0fe30ae07f3c800562a025e27 . CHANGES SINCE LAST ACTION

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

cor3ntin accepted this revision. cor3ntin added a comment. Thanks for changing the name. It looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 ___ cfe-commits mailing list

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added a comment. In D105648#2866893 , @ABataev wrote: > LG, but wait for others' comments/suggestions/etc. Thank you for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but wait for others' comments/suggestions/etc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357487. aaron.ballman added a comment. Enable attribute support as an extension (with the usual diagnostics). Note that this adds some new diagnostic groups for OpenMP as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked 8 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357479. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Change `annot_pragma_openmp_from_attr` into `annot_attr_openmp` based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } aaron.ballman wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > ABataev wrote: > > > > erichkeane wrote: > >

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357338. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Address review feedback, add a link to this review to the OpenMP status page for the feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } aaron.ballman wrote: > erichkeane wrote: > > ABataev wrote: > > > erichkeane wrote: > > > > aaron.ballman wrote: >

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added a comment. Looks good, in general, just pre-commit formatting changes. Comment at: clang/lib/Basic/Attributes.cpp:27 + if (LangOpts.OpenMP >= 51 && ScopeName == "omp") +return Name == "directive" || Name == "sequence"; + Better to return int

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } erichkeane wrote: > ABataev wrote: > > erichkeane wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > >

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4473-4486 +void Parser::ParseCXX11Attributes(ParsedAttributesWithRange , + SourceLocation *EndLoc) { assert(standardAttributesAllowed()); SourceLocation

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357327. aaron.ballman marked 8 inline comments as done. aaron.ballman added a comment. Addressing review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 Files:

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } ABataev wrote: > erichkeane wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > Another place to make the

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Another place to make the same comment :D I wonder

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:869 PRAGMA_ANNOTATION(pragma_openmp) +PRAGMA_ANNOTATION(pragma_openmp_from_attr) PRAGMA_ANNOTATION(pragma_openmp_end) aaron.ballman wrote: > erichkeane wrote: > >

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:869 PRAGMA_ANNOTATION(pragma_openmp) +PRAGMA_ANNOTATION(pragma_openmp_from_attr) PRAGMA_ANNOTATION(pragma_openmp_end)

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:869 PRAGMA_ANNOTATION(pragma_openmp) +PRAGMA_ANNOTATION(pragma_openmp_from_attr) PRAGMA_ANNOTATION(pragma_openmp_end) `pragma_openmp_from_attr`? Funny since it isn't a

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2803-2808 + bool MaybeParseCXX11Attributes(ParsedAttributesWithRange , + SourceLocation *EndLoc = nullptr, bool

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman created this revision. aaron.ballman added reviewers: ABataev, jdoerfert, erichkeane, bader, rsmith. Herald added subscribers: dexonsmith, zzheng, guansong, yaxunl. aaron.ballman requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang.