[PATCH] D105926: [PowerPC] Extra test case for LDARX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a7711f33a04: [PowerPC] Extra test case for LDARX (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail accepted this revision. lkail added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.org/D105926

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap updated this revision to Diff 360114. Conanap added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Moved to llvm/test/CodeGen/PowerPC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail requested changes to this revision. lkail added a comment. This revision now requires changes to proceed. Looks we should put it in `llvm/test/CodeGen/PowerPC`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-check-ldarx-opt.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ This

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap reopened this revision. Conanap added a comment. This revision is now accepted and ready to land. Had to revert this as I'm seeing failures on buildbots not owned by us. The error is: llc: error: : error: unable to get target for 'powerpc64le-unknown-linux-gnu', see --version and

[PATCH] D105926: [PowerPC] Extra test case for LDARX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3e77e7a842: [PowerPC] Extra test case for LDARX (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105926: [PowerPC] Extra test case for LDARX

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.org/D105926

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap updated this revision to Diff 359681. Conanap added a comment. Removed metadata, -O3 to generate the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.org/D105926 Files:

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap added a comment. In D105926#2885291 , @teemperor wrote: > Sorry for raising an unrelated topic here, but I can't reach @Conanap > directly via the mail from the git commits: @Conanap could you please create > the git branches for your patches

[PATCH] D105926: [PowerPC] Extra test case for LDARX

teemperor added a comment. Sorry for raising an unrelated topic here, but I can't reach @Conanap directly via the mail from the git commits: @Conanap could you please create the git branches for your patches in your own Github fork instead of the main LLVM repo? LLVM's policy is to have

[PATCH] D105926: [PowerPC] Extra test case for LDARX

nemanjai added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-check-ldarx-opt.ll:149 + +attributes #0 = { noinline nounwind optnone uwtable "frame-pointer"="all" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8"

[PATCH] D105926: [PowerPC] Extra test case for LDARX

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-check-ldarx-opt.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +;

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Conanap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An extra test case added for the builtin __LDARX. Repository: rG LLVM Github Monorepo