[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 added a comment. In D106888#3513001 , @MaskRay wrote: > I'll wait a bit before pushing to check whether that further opinions. Thanks! I don't have commit access, so could you please commit on my behalf when appropriate? Wende Tan CHANGES SINCE

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

MaskRay added a comment. I'll wait a bit before pushing to check whether that further opinions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 updated this revision to Diff 427901. twd2 added a comment. Herald added subscribers: sunshaoce, StephenFan, arichardson. Herald added a project: All. Add tests as suggested. Use `tail xxx@plt` instruction instead of manually `auipc` + `jr`, which eliminates issues when linking

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

MaskRay added a comment. Needs a test in llvm/test/Transforms/LowerTypeTests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

luismarques added a comment. In D106888#2954788 , @twd2 wrote: > Hi, you can check here: > https://buildkite.com/llvm-project/premerge-checks/builds/49755#814fd222-2e5a-4400-824d-d1a1f1293c01 > The clang-tidy failed due to the invalid case style for

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 added a comment. In D106888#2954571 , @luismarques wrote: > In D106888#2954425 , @asb wrote: > >> Is it possible to write a test case for this? > > Good question. I had checked that the AArch64

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

luismarques added a comment. In D106888#2954425 , @asb wrote: > Is it possible to write a test case for this? Good question. I had checked that the AArch64 implementation had included a test, but I think that was only for new target-specific stuff,

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

asb added a comment. Is it possible to write a test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 added a comment. Ping? The build failure is due to the name of the newly introduced `kRISCVJumpTableEntrySize`. Though I think we can put these magic numbers (4 and 8) just into `LowerTypeTestsModule::getJumpTableEntrySize`.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 created this revision. twd2 added reviewers: MaskRay, asb, eugenis, pcc. twd2 created this object with edit policy "Administrators". twd2 added projects: LLVM, Sanitizers, clang. Herald added subscribers: ormris, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217,