[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

2022-04-13 Thread Gabor Marton via Phabricator via cfe-commits
martong requested changes to this revision. martong added a comment. This revision now requires changes to proceed. I am not sure if this patch makes sense at all because the adjustment handling logic is restricted to handle SymInt expressions only. Comment at:

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

2022-04-11 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. Herald added a project: All. I checked the tests file on the latest sources. It passes even without your changes. Maybe this patch is already outdated. Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:82-86 if

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

2021-08-06 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D107636#2931302 , @steakhal wrote: > Seems reasonable to me. Let's wait for someone else as well. Sure, NP. > This is a really elegant patch, I should tell! Thanks! I guess my take on this, that this path to the solver

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

2021-08-06 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Seems reasonable to me. Let's wait for someone else as well. This is a really elegant patch, I should tell! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

2021-08-06 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this