sdardis updated this revision to Diff 41283.
sdardis added a comment.
Nit addressed.
Daniel or Aaron, can one of you commit on my behalf? Thanks.
Aaron, thanks for the review.
http://reviews.llvm.org/D10802
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, once one minor nit is fixed. Thank you for working on this!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:257
@@ +256,3 @@
+ "MIPS 'interrupt'
sdardis updated this revision to Diff 41041.
sdardis added a comment.
Updated text of return type/parameters warning to Aaron's suggestion.
Dropped '\' escape characters from warning/error text.
Removed mips16/nomips16 check.
Tweak of comment in handleMipsInterruptAttr.
sdardis updated this revision to Diff 40782.
sdardis marked 4 inline comments as done.
sdardis added a comment.
Updated comments, used cast as suggested, added mutual exclusion check for
mips16+interrupt combination.
Extended mips16/nomips16 attribute handlers for mutual exclusion, add to
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:256
@@ +255,3 @@
+def warn_mips_interrupt_attribute : Warning<
+ "function %0 must %select{take no arguments|have the \'void\' return type}1"
+ " for the 'interrupt' attribute for
sdardis updated this revision to Diff 40382.
sdardis marked 12 inline comments as done.
sdardis added a comment.
Updated documentation text.
Switched the various hard failures to semantic warnings/failures.
Strangely, the 'interrupt' attribute on a non-function defaults to a warning.
Thanks.
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:255
@@ -254,1 +254,3 @@
def err_parameter_name_omitted : Error<"parameter name omitted">;
+def err_excess_arguments : Error<"function %0 has too many arguments">;
+def
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
This is coming along nicely! There are some minor nits that should be trivial
to fix, but the fatal errors need to become semantic errors, and some tests are
missing.
sdardis updated this revision to Diff 38533.
sdardis added a comment.
Updated tests along the lines of what vkalintiris did for llvm.
http://reviews.llvm.org/D10802
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
sdardis updated the summary for this revision.
sdardis updated this revision to Diff 38102.
sdardis marked 3 inline comments as done.
sdardis added a comment.
Nits addressed and XFAIL tests added for functions having arguments and the
interrupt attribute.
Test added to cover semantic warnings.
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM with a few nits
Comment at: include/clang/Basic/Attr.td:841-842
@@ +840,4 @@
+def MipsInterrupt : InheritableAttr, TargetSpecificAttr {
+ // NOTE: if you add any
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman requested changes to this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Missing tests for the semantic warnings. For instance, I don't see any
12 matches
Mail list logo
