[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0391dfc737e: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute (authored by glider). Repository: rG LLVM Github

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added a comment. In D108029#2954604 , @glider wrote: > In D108029#2954566 , @melver wrote: > >> llvm/docs/LangRef.rst also needs a corresponding change. > > Right, will do. I thought LangRef was missing

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 367759. glider added a comment. Updated LangRef.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 Files: clang/include/clang/Basic/Attr.td

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver accepted this revision. melver added a comment. LGTM with the LangRef change. Thanks! Comment at: llvm/lib/AsmParser/LLLexer.cpp:646 KEYWORD(dereferenceable_or_null); + KEYWORD(disable_sanitizer_instrumentation); KEYWORD(elementtype); glider

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added a comment. In D108029#2954566 , @melver wrote: > llvm/docs/LangRef.rst also needs a corresponding change. Right, will do. I thought LangRef was missing the sanitizer bits as well, and was planning to add them together, but apparently I was

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added a comment. llvm/docs/LangRef.rst also needs a corresponding change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 ___ cfe-commits mailing list

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added inline comments. Comment at: llvm/lib/AsmParser/LLLexer.cpp:646 KEYWORD(dereferenceable_or_null); + KEYWORD(disable_sanitizer_instrumentation); KEYWORD(elementtype); Do the tests pass? There should also be the code that actually turns the

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 367480. glider added a comment. Updated BitcodeReader.cpp and several tests per Marco's suggestion Renamed ATTR_DISABLE_SANITIZER_INSTRUMENTATION to ATTR_KIND_DISABLE_SANITIZER_INSTRUMENTATION Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added inline comments. Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:674 ATTR_KIND_ELEMENTTYPE = 77, + ATTR_DISABLE_SANITIZER_INSTRUMENTATION = 78, }; Missing "_KIND_" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added inline comments. Comment at: clang/test/CodeGen/attr-no-sanitize-coverage.c:1 +// RUN: %clang_cc1 -debug-info-kind=limited %s -emit-llvm -o - | FileCheck %s + This file says it's called attr-no-sanitize-coverage.c, I think that's the wrong name.

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added inline comments. Comment at: llvm/include/llvm/IR/Attributes.td:90 +/// Do not instrument function with sanitizers. +def DisableSanitizerInstrumentation: EnumAttr<"disable_sanitizer_instrumentation", [FnAttr]>; + melver wrote: > There's this

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 366887. glider added a comment. Fix the docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 Files: clang/include/clang/Basic/Attr.td

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added inline comments. Comment at: llvm/include/llvm/IR/Attributes.td:90 +/// Do not instrument function with sanitizers. +def DisableSanitizerInstrumentation: EnumAttr<"disable_sanitizer_instrumentation", [FnAttr]>; + There's this long-tail of changes

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Clang bits LGTM with a few minor documentation nits. Comment at: clang/include/clang/Basic/AttrDocs.td:2598-2599 + let Content = [{ +Use the

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2945 + let Spellings = [Clang<"disable_sanitizer_instrumentation">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [DisableSanitizerInstrumentationDocs];

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 366845. glider added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 Files: clang/include/clang/Basic/Attr.td

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2945 + let Spellings = [Clang<"disable_sanitizer_instrumentation">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [DisableSanitizerInstrumentationDocs]; Do