[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe611b1da84b: [clang] Move the soname declaration in a variable at the top of the file (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 Files: clang/tools/libclang/CMakeLists.txt Index: clang/tools/libclang/CMakeLists.txt === --- clang/tools/libclang/CMakeLists.txt +++ clang/tools/libclang/CMakeLists.txt @@ -1,3 +1,9 @@ +# The SOVERSION should be updated only if a change is made to the libclang +# ABI, and when it is updated, it should be updated to the current +# LLVM_VERSION_MAJOR. +# Please also see clang/tools/libclang/libclang.map +set(CLANG_SONAME 13) + set(SOURCES ARCMigrate.cpp BuildSystem.cpp @@ -171,12 +177,9 @@ set_property(SOURCE ARCMigrate.cpp APPEND PROPERTY OBJECT_DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map) -# The SOVERSION should be updated only if a change is made to the libclang -# ABI, and when it is updated, it should be updated to the current -# LLVM_VERSION_MAJOR. set_target_properties(libclang PROPERTIES VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX} - SOVERSION 13) + SOVERSION ${CLANG_SONAME}) endif() endif() Index: clang/tools/libclang/CMakeLists.txt === --- clang/tools/libclang/CMakeLists.txt +++ clang/tools/libclang/CMakeLists.txt @@ -1,3 +1,9 @@ +# The SOVERSION should be updated only if a change is made to the libclang +# ABI, and when it is updated, it should be updated to the current +# LLVM_VERSION_MAJOR. +# Please also see clang/tools/libclang/libclang.map +set(CLANG_SONAME 13) + set(SOURCES ARCMigrate.cpp BuildSystem.cpp @@ -171,12 +177,9 @@ set_property(SOURCE ARCMigrate.cpp APPEND PROPERTY OBJECT_DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map) -# The SOVERSION should be updated only if a change is made to the libclang -# ABI, and when it is updated, it should be updated to the current -# LLVM_VERSION_MAJOR. set_target_properties(libclang PROPERTIES VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX} - SOVERSION 13) + SOVERSION ${CLANG_SONAME}) endif() endif() ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file
sylvestre.ledru updated this revision to Diff 368126. sylvestre.ledru added a comment. Move the comment too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 Files: clang/tools/libclang/CMakeLists.txt Index: clang/tools/libclang/CMakeLists.txt === --- clang/tools/libclang/CMakeLists.txt +++ clang/tools/libclang/CMakeLists.txt @@ -1,3 +1,9 @@ +# The SOVERSION should be updated only if a change is made to the libclang +# ABI, and when it is updated, it should be updated to the current +# LLVM_VERSION_MAJOR. +# Please also see clang/tools/libclang/libclang.map +set(CLANG_SONAME 13) + set(SOURCES ARCMigrate.cpp BuildSystem.cpp @@ -171,12 +177,9 @@ set_property(SOURCE ARCMigrate.cpp APPEND PROPERTY OBJECT_DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map) -# The SOVERSION should be updated only if a change is made to the libclang -# ABI, and when it is updated, it should be updated to the current -# LLVM_VERSION_MAJOR. set_target_properties(libclang PROPERTIES VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX} - SOVERSION 13) + SOVERSION ${CLANG_SONAME}) endif() endif() Index: clang/tools/libclang/CMakeLists.txt === --- clang/tools/libclang/CMakeLists.txt +++ clang/tools/libclang/CMakeLists.txt @@ -1,3 +1,9 @@ +# The SOVERSION should be updated only if a change is made to the libclang +# ABI, and when it is updated, it should be updated to the current +# LLVM_VERSION_MAJOR. +# Please also see clang/tools/libclang/libclang.map +set(CLANG_SONAME 13) + set(SOURCES ARCMigrate.cpp BuildSystem.cpp @@ -171,12 +177,9 @@ set_property(SOURCE ARCMigrate.cpp APPEND PROPERTY OBJECT_DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map) -# The SOVERSION should be updated only if a change is made to the libclang -# ABI, and when it is updated, it should be updated to the current -# LLVM_VERSION_MAJOR. set_target_properties(libclang PROPERTIES VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX} - SOVERSION 13) + SOVERSION ${CLANG_SONAME}) endif() endif() ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file
MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:176 # The SOVERSION should be updated only if a change is made to the libclang # ABI, and when it is updated, it should be updated to the current The comment should be lifted as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file
sylvestre.ledru created this revision. sylvestre.ledru added reviewers: tstellar, MaskRay. Herald added a subscriber: mgorny. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, it is a bit buried in the file even if this is pretty important for distro. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108533 Files: clang/tools/libclang/CMakeLists.txt Index: clang/tools/libclang/CMakeLists.txt === --- clang/tools/libclang/CMakeLists.txt +++ clang/tools/libclang/CMakeLists.txt @@ -48,6 +48,8 @@ clangTooling ) +SET(CLANG_SONAME 13) + if (CLANG_ENABLE_ARCMT) list(APPEND LIBS clangARCMigrate) endif () @@ -176,7 +178,7 @@ # LLVM_VERSION_MAJOR. set_target_properties(libclang PROPERTIES VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX} - SOVERSION 13) + SOVERSION ${CLANG_SONAME}) endif() endif() Index: clang/tools/libclang/CMakeLists.txt === --- clang/tools/libclang/CMakeLists.txt +++ clang/tools/libclang/CMakeLists.txt @@ -48,6 +48,8 @@ clangTooling ) +SET(CLANG_SONAME 13) + if (CLANG_ENABLE_ARCMT) list(APPEND LIBS clangARCMigrate) endif () @@ -176,7 +178,7 @@ # LLVM_VERSION_MAJOR. set_target_properties(libclang PROPERTIES VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX} - SOVERSION 13) + SOVERSION ${CLANG_SONAME}) endif() endif() ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits