Topotuna added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:1729
bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300);
+bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300;
// OpenCL C v3.0 s6.3.3 - OpenCL image types require
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Topotuna marked an inline comment as done.
Closed by commit rG3b9470a6c46d: [OpenCL] Supports optional image types in C++
for OpenCL 2021 (authored by Topotuna).
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109002/new/
https://reviews.llvm.org/D109002
___
cfe-commits mailing
Topotuna marked an inline comment as done.
Topotuna added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:1729
bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300);
+bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300;
// OpenCL
Topotuna updated this revision to Diff 370237.
Topotuna added a comment.
Boolean variable renamed to `IsOpenCLC30Compatible`. `FIXME` comment added.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109002/new/
https://reviews.llvm.org/D109002
Files:
clang/lib/Sema/SemaType.cpp
Anastasia added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:1729
bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300);
+bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300;
// OpenCL C v3.0 s6.3.3 - OpenCL image types
Topotuna added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:1729
bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300);
+bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300;
// OpenCL C v3.0 s6.3.3 - OpenCL image types require
Anastasia added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:1729
bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300);
+bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300;
// OpenCL C v3.0 s6.3.3 - OpenCL image types
Topotuna created this revision.
Topotuna added a reviewer: Anastasia.
Herald added subscribers: ldrumm, yaxunl.
Topotuna requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Adds support for a feature macro `__opencl_c_images` in C++ for
OpenCL