subject:"\[PATCH\] D110911\: \[analyzer\]\[NFC\] Add RangeSet\:\:dump"

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

2021-10-06 Thread Gabor Marton via Phabricator via cfe-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rGb8f6c85a831f: [analyzer][NFC] Add RangeSet::dump (authored 
by martong).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110911/new/

https://reviews.llvm.org/D110911

Files:
  
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
  clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp


Index: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
===
--- clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
+++ clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
@@ -494,15 +494,17 @@
   return intersect(From, Upper, Lower);
 }
 
-void Range::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void Range::dump(raw_ostream ) const {
   OS << '[' << toString(From(), 10) << ", " << toString(To(), 10) << ']';
 }
+LLVM_DUMP_METHOD void Range::dump() const { dump(llvm::errs()); }
 
-void RangeSet::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void RangeSet::dump(raw_ostream ) const {
   OS << "{ ";
   llvm::interleaveComma(*this, OS, [](const Range ) { R.dump(OS); });
   OS << " }";
 }
+LLVM_DUMP_METHOD void RangeSet::dump() const { dump(llvm::errs()); }
 
 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef)
 
Index: 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
===
--- 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
+++ 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
@@ -48,6 +48,7 @@
 ID.AddPointer(());
   }
   void dump(raw_ostream ) const;
+  void dump() const;
 
   // In order to keep non-overlapping ranges sorted, we can compare only From
   // points.
@@ -282,6 +283,7 @@
   bool contains(llvm::APSInt Point) const { return containsImpl(Point); }
 
   void dump(raw_ostream ) const;
+  void dump() const;
 
   bool operator==(const RangeSet ) const { return *Impl == *Other.Impl; }
   bool operator!=(const RangeSet ) const { return !(*this == Other); }


Index: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
===
--- clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
+++ clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
@@ -494,15 +494,17 @@
   return intersect(From, Upper, Lower);
 }
 
-void Range::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void Range::dump(raw_ostream ) const {
   OS << '[' << toString(From(), 10) << ", " << toString(To(), 10) << ']';
 }
+LLVM_DUMP_METHOD void Range::dump() const { dump(llvm::errs()); }
 
-void RangeSet::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void RangeSet::dump(raw_ostream ) const {
   OS << "{ ";
   llvm::interleaveComma(*this, OS, [](const Range ) { R.dump(OS); });
   OS << " }";
 }
+LLVM_DUMP_METHOD void RangeSet::dump() const { dump(llvm::errs()); }
 
 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef)
 
Index: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
===
--- clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
+++ clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
@@ -48,6 +48,7 @@
 ID.AddPointer(());
   }
   void dump(raw_ostream ) const;
+  void dump() const;
 
   // In order to keep non-overlapping ranges sorted, we can compare only From
   // points.
@@ -282,6 +283,7 @@
   bool contains(llvm::APSInt Point) const { return containsImpl(Point); }
 
   void dump(raw_ostream ) const;
+  void dump() const;
 
   bool operator==(const RangeSet ) const { return *Impl == *Other.Impl; }
   bool operator!=(const RangeSet ) const { return !(*this == Other); }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

2021-10-06 Thread Gabor Marton via Phabricator via cfe-commits

martong added a comment.

Thanks for the reivew!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110911/new/

https://reviews.llvm.org/D110911

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

2021-10-06 Thread Denys Petrov via Phabricator via cfe-commits

ASDenysPetrov accepted this revision.
ASDenysPetrov added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110911/new/

https://reviews.llvm.org/D110911

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

2021-10-06 Thread Gabor Marton via Phabricator via cfe-commits

martong updated this revision to Diff 377482.
martong added a comment.

- Rebase
- Mark the dump methods with LLVM_DUMP_METHOD
- Add Range::dump


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110911/new/

https://reviews.llvm.org/D110911

Files:
  
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
  clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp


Index: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
===
--- clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
+++ clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
@@ -494,15 +494,17 @@
   return intersect(From, Upper, Lower);
 }
 
-void Range::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void Range::dump(raw_ostream ) const {
   OS << '[' << toString(From(), 10) << ", " << toString(To(), 10) << ']';
 }
+LLVM_DUMP_METHOD void Range::dump() const { dump(llvm::errs()); }
 
-void RangeSet::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void RangeSet::dump(raw_ostream ) const {
   OS << "{ ";
   llvm::interleaveComma(*this, OS, [](const Range ) { R.dump(OS); });
   OS << " }";
 }
+LLVM_DUMP_METHOD void RangeSet::dump() const { dump(llvm::errs()); }
 
 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef)
 
Index: 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
===
--- 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
+++ 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
@@ -48,6 +48,7 @@
 ID.AddPointer(());
   }
   void dump(raw_ostream ) const;
+  void dump() const;
 
   // In order to keep non-overlapping ranges sorted, we can compare only From
   // points.
@@ -282,6 +283,7 @@
   bool contains(llvm::APSInt Point) const { return containsImpl(Point); }
 
   void dump(raw_ostream ) const;
+  void dump() const;
 
   bool operator==(const RangeSet ) const { return *Impl == *Other.Impl; }
   bool operator!=(const RangeSet ) const { return !(*this == Other); }


Index: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
===
--- clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
+++ clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
@@ -494,15 +494,17 @@
   return intersect(From, Upper, Lower);
 }
 
-void Range::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void Range::dump(raw_ostream ) const {
   OS << '[' << toString(From(), 10) << ", " << toString(To(), 10) << ']';
 }
+LLVM_DUMP_METHOD void Range::dump() const { dump(llvm::errs()); }
 
-void RangeSet::dump(raw_ostream ) const {
+LLVM_DUMP_METHOD void RangeSet::dump(raw_ostream ) const {
   OS << "{ ";
   llvm::interleaveComma(*this, OS, [](const Range ) { R.dump(OS); });
   OS << " }";
 }
+LLVM_DUMP_METHOD void RangeSet::dump() const { dump(llvm::errs()); }
 
 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef)
 
Index: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
===
--- clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
+++ clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
@@ -48,6 +48,7 @@
 ID.AddPointer(());
   }
   void dump(raw_ostream ) const;
+  void dump() const;
 
   // In order to keep non-overlapping ranges sorted, we can compare only From
   // points.
@@ -282,6 +283,7 @@
   bool contains(llvm::APSInt Point) const { return containsImpl(Point); }
 
   void dump(raw_ostream ) const;
+  void dump() const;
 
   bool operator==(const RangeSet ) const { return *Impl == *Other.Impl; }
   bool operator!=(const RangeSet ) const { return !(*this == Other); }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

2021-10-01 Thread Denys Petrov via Phabricator via cfe-commits

ASDenysPetrov added a comment.

In D110911#3035911 , @steakhal wrote:

> Please mark both of them `LLVM_DUMP_METHOD`s. This way they will be stripped 
> from release builds according to their documentation.

And `Range::dump` as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110911/new/

https://reviews.llvm.org/D110911

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

2021-10-01 Thread Balázs Benics via Phabricator via cfe-commits

steakhal added a comment.

Please mark both of them `LLVM_DUMP_METHOD`s. This way they will be stripped 
from release builds according to their documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110911/new/

https://reviews.llvm.org/D110911

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

2021-10-01 Thread Gabor Marton via Phabricator via cfe-commits

martong created this revision.
martong added reviewers: steakhal, ASDenysPetrov, manas, NoQ, vabridgers.
Herald added subscribers: gamesh411, dkrupp, donat.nagy, Szelethus, 
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, 
whisperity.
Herald added a reviewer: Szelethus.
martong requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This tiny change improves the debugging experience of the solver a lot!


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110911

Files:
  
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
  clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp


Index: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
===
--- clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
+++ clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
@@ -504,6 +504,8 @@
   OS << " }";
 }
 
+void RangeSet::dump() const { dump(llvm::errs()); }
+
 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef)
 
 namespace {
Index: 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
===
--- 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
+++ 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
@@ -282,6 +282,7 @@
   bool contains(llvm::APSInt Point) const { return containsImpl(Point); }
 
   void dump(raw_ostream ) const;
+  void dump() const;
 
   bool operator==(const RangeSet ) const { return *Impl == *Other.Impl; }
   bool operator!=(const RangeSet ) const { return !(*this == Other); }


Index: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
===
--- clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
+++ clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
@@ -504,6 +504,8 @@
   OS << " }";
 }
 
+void RangeSet::dump() const { dump(llvm::errs()); }
+
 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef)
 
 namespace {
Index: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
===
--- clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
+++ clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
@@ -282,6 +282,7 @@
   bool contains(llvm::APSInt Point) const { return containsImpl(Point); }
 
   void dump(raw_ostream ) const;
+  void dump() const;
 
   bool operator==(const RangeSet ) const { return *Impl == *Other.Impl; }
   bool operator!=(const RangeSet ) const { return !(*this == Other); }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

7 matches

Site Navigation

Mail list logo

Footer information