This revision was automatically updated to reflect the committed changes.
Closed by commit rG0198d76e1e76: [Bazel] Get `//clang` building on Windows with
clang-cl. (authored by chandlerc).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
chandlerc added inline comments.
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1828
],
-copts = [
-"-Wno-uninitialized",
-],
+copts = select({
+"@bazel_tools//src/conditions:windows": [],
rnk wrote:
> Enabling
chandlerc added a comment.
Thanks, making suggested changes and then landing!
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364
+# Clang-specific define on non-Windows platforms.
+"CLANG_HAVE_RLIMITS=1",
+],
GMNGeoffrey accepted this revision.
GMNGeoffrey added inline comments.
This revision is now accepted and ready to land.
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364
+# Clang-specific define on non-Windows platforms.
+
rnk added inline comments.
Comment at: utils/bazel/.bazelrc:81
+build:windows --copt=/Oi --host_copt=/Oi
+build:windows --cxxopt=/Zc:rvalueCast --host_cxxopt=/Zc:rvalueCast
+
Try adding `/permissive-` to get more conforming behavior from clang-cl. If
that
chandlerc requested review of this revision.
chandlerc added a comment.
PTAL, and thanks for feedback so far!
Comment at: clang/include/clang/Basic/Builtins.def:1059
+#undef strcasecmp
+#undef strncasecmp
+
rnk wrote:
> thakis wrote:
> > GMNGeoffrey wrote:
> >
chandlerc updated this revision to Diff 383634.
chandlerc marked 5 inline comments as done.
chandlerc edited the summary of this revision.
chandlerc added a reviewer: rnk.
chandlerc added a comment.
Major update to better fix some of the issues here. No longer requires any
changes outside of
GMNGeoffrey added inline comments.
Comment at:
utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h:81
/* The LLVM product name and version */
#define BACKEND_PACKAGE_STRING "LLVM 12.0.0git"
rnk wrote:
> Unrelated to your change, but is this
rnk added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:1059
+#undef strcasecmp
+#undef strncasecmp
+
thakis wrote:
> GMNGeoffrey wrote:
> > chandlerc wrote:
> > > thakis wrote:
> > > > Why do we need this with bazel but not with other
thakis added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:1059
+#undef strcasecmp
+#undef strncasecmp
+
GMNGeoffrey wrote:
> chandlerc wrote:
> > thakis wrote:
> > > Why do we need this with bazel but not with other windows builds?
> > I
GMNGeoffrey added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:1059
+#undef strcasecmp
+#undef strncasecmp
+
chandlerc wrote:
> thakis wrote:
> > Why do we need this with bazel but not with other windows builds?
> I don't know how this
chandlerc added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:1059
+#undef strcasecmp
+#undef strncasecmp
+
thakis wrote:
> Why do we need this with bazel but not with other windows builds?
I don't know how this never was hit by other
thakis added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:1059
+#undef strcasecmp
+#undef strncasecmp
+
Why do we need this with bazel but not with other windows builds?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112399/new/
GMNGeoffrey accepted this revision.
GMNGeoffrey added inline comments.
This revision is now accepted and ready to land.
Comment at:
utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h:78
/* Define if we have sys/resource.h (rlimits) */
-#define
chandlerc created this revision.
chandlerc added a reviewer: GMNGeoffrey.
Herald added a subscriber: mcrosier.
chandlerc requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
This required substantially more invasive changes I'm afraid.
15 matches
Mail list logo
