This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5cff77c23f43: [clang][ARM] PACBTI-M assembly support
(authored by stuij, committed by Zeno zeno@Zenos-MacBook-Pro.local).
Repository:
rG LLVM
stuij updated this revision to Diff 390314.
stuij marked 2 inline comments as done.
stuij added a comment.
addressed review comment and clang-format suggestions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112420/new/
labrinea accepted this revision.
labrinea added a comment.
This revision is now accepted and ready to land.
Looks like you've addressed Oliver's comments. I don't have any new suggestions
from my end. Just make sure you've removed the test xfail before merging.
Comment at:
stuij marked 6 inline comments as done.
stuij added a comment.
A slight amendment to the description of the just uploaded patch amendment:
PACG has also been made conditional.
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6441
+ Mnemonic == "csetm" ||
+
stuij updated this revision to Diff 384721.
stuij added a comment.
Herald added subscribers: ormris, steven_wu.
addressed review comments:
- Added predicate operand to bxaut, autg. They will now also behave correctly
in IT blocks.
- Adjusted operator constraints for a number of instructions so
vhscampos added inline comments.
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:4083
def : t2InstAlias<"csdb$p", (t2HINT 20, pred:$p), 1>;
+def : t2InstAlias<"pacbti$p r12,lr,sp", (t2HINT 13, pred:$p), 1>;
+def : t2InstAlias<"bti$p", (t2HINT 15, pred:$p), 1>;
ostannard added inline comments.
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:4083
def : t2InstAlias<"csdb$p", (t2HINT 20, pred:$p), 1>;
+def : t2InstAlias<"pacbti$p r12,lr,sp", (t2HINT 13, pred:$p), 1>;
+def : t2InstAlias<"bti$p", (t2HINT 15, pred:$p), 1>;
stuij created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
stuij requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Introduce assembly support for Armv8.1-M PACBTI extension. This is an optional
