stuij added a comment.
@erichkeane : thanks so much for going through the trouble to see what the
problem is!
I've put up a fix with your suggested change at https://reviews.llvm.org/D115141
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
erichkeane added a comment.
I just found that build failure in our downstream, and did a little
investigation. Running the clang-invocations directly resulted in :
[ekeane1@scsel-clx-24 llvm]$
/localdisk2/ekeane1/workspaces/xmain-web/builds/xmainefi2linux_debug/llvm/bin/clang
-target
stuij added a comment.
Yes, pushed a temporary fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
RKSimon added a comment.
@stuij This is causing buildbot failures, please can you take a look?
https://lab.llvm.org/buildbot/#/builders/139
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe3b2f0226bc0: [clang][ARM] PACBTI-M frontend support
(authored by stuij).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
stuij updated this revision to Diff 390958.
stuij added a comment.
rebased and resolved merge conflict
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
Files:
stuij updated this revision to Diff 390316.
stuij added a comment.
minor clang-format conformance changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
Files:
stuij updated this revision to Diff 390021.
stuij added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
Files:
clang/include/clang/Basic/DiagnosticDriverKinds.td
chill added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:6377
+
+static const char *SignReturnAddrStr[] = {"none", "non-leaf", "all"};
+Fn->addFnAttr("sign-return-address",
vhscampos wrote:
> I reckon selecting the string using a
vhscampos added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2979
+def warn_unsupported_branch_protection_spec : Warning<
+ "unsupported branch protection specification '%0'">,
InGroup;
+
Still need to remove extraneous
chill added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
StringRef ) const {
- llvm::AArch64::ParsedBranchProtection PBP;
- if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+
stuij updated this revision to Diff 384724.
stuij added a comment.
removed stray block duplicating the behaviour of CollectARMPACBTIOptions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
Files:
danielkiss added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
StringRef ) const {
- llvm::AArch64::ParsedBranchProtection PBP;
- if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+
aaron.ballman added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
StringRef ) const {
- llvm::AArch64::ParsedBranchProtection PBP;
- if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+
chill added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
StringRef ) const {
- llvm::AArch64::ParsedBranchProtection PBP;
- if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+
vhscampos added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
StringRef ) const {
- llvm::AArch64::ParsedBranchProtection PBP;
- if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2980
+def warn_unsupported_branch_protection_spec : Warning<
+ "unsupported branch protection specification '%0'">,
InGroup;
+
Comment at:
ostannard added a comment.
In the commit message: s/armclang/clang/
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1832
// Enable/disable return address signing and indirect branch targets.
if (Arg *A = Args.getLastArg(options::OPT_msign_return_address_EQ,
stuij created this revision.
Herald added subscribers: dexonsmith, hiraditya, kristof.beyls.
Herald added a reviewer: aaron.ballman.
stuij requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Handle branch protection option on
19 matches
Mail list logo
