[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka added a comment. In D112732#3107387 , @aeubanks wrote: > can we rename "asan-module" to "asan" after this change? and remove the extra > "asan-pipeline"/"asan-function-pipeline" parsing callbacks in > NewPMDriver.cpp? and previously we had

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289 + } + Modified |= ModuleSanitizer.instrumentModule(M); + if (Modified) vitalybuka wrote: > kstoimenov wrote: > > At first I had module sanitizer run

[PATCH] D112732: [ASan] Process functions in Asan module pass

aeubanks added a comment. can we rename "asan-module" to "asan" after this change? and remove the extra "asan-pipeline"/"asan-function-pipeline" parsing callbacks in NewPMDriver.cpp? and previously we had `-passes=require` because a function pass couldn't invoke a module analysis, but that's

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was automatically updated to reflect the committed changes. Closed by commit rGa55c4ec1cee7: [ASan] Process functions in Asan module pass (authored by kstoimenov). Changed prior to commit: https://reviews.llvm.org/D112732?vs=384544=384571#toc Repository: rG LLVM Github

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384544. kstoimenov added a comment. After merging D113072 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka updated this revision to Diff 384539. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn));

[PATCH] D112732: [ASan] Process functions in Asan module pass

rupprecht added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn));

[PATCH] D112732: [ASan] Process functions in Asan module pass

rupprecht added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn));

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76ea87b94e5c: [ASan] Process functions in Asan module pass (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384515. kstoimenov added a comment. After rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384488. kstoimenov marked 3 inline comments as done. kstoimenov added a comment. Moved module after function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384467. kstoimenov added a comment. Moved empty check to the top of the function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384465. kstoimenov added a comment. Moved module instumentation back ahead of function instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Lets keep AddressSanitizerPass for a while, we don't have to remove it in the same patch Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289 +

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka updated this revision to Diff 384303. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp