[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG698584f89b8f: [IR] Remove unbounded as possible value for vscale_range minimum (authored by c-rhodes). Changed prior to commit:

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:482 +return std::pair( +LangOpts.VScaleMin ? LangOpts.VScaleMin : 1, 16); + paulwalker-arm wrote: > This part is no longer needed because to get here you already know >

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. One minor issue but otherwise looks good. Comment at: clang/lib/Basic/Targets/AArch64.cpp:482 +return std::pair( +LangOpts.VScaleMin ?

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes updated this revision to Diff 392002. c-rhodes added a comment. Revert `LangOpt.VScaleMin` default to 0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.llvm.org/D113294 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin,

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin,

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes marked an inline comment as done. c-rhodes added a comment. In D113294#3170007 , @paulwalker-arm wrote: > I agree, it's the change to VScaleMin that has caused the issue. If the > LangOpts default can remain as 0 and you can still achieve

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes updated this revision to Diff 391668. c-rhodes added a comment. Revert to previous behaviour where both the min/max Clang flags override SVE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.llvm.org/D113294 Files:

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm added a comment. I agree, it's the change to VScaleMin that has caused the issue. If the LangOpts default can remain as 0 and you can still achieve what you're after then that would be perfect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin,

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm requested changes to this revision. paulwalker-arm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes marked 4 inline comments as done. c-rhodes added a comment. In D113294#3115354 , @sdesmalen wrote: > It would be nice if the LLVM interfaces could be updated as well (could also > be done in a follow-up patch) Thanks for reviewing, I'll create

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes updated this revision to Diff 385732. c-rhodes added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.llvm.org/D113294 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic/LangOptions.def

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

sdesmalen added a comment. It would be nice if the LLVM interfaces could be updated as well (could also be done in a follow-up patch) From: std::pair getVScaleRangeArgs() To: Optional getVScaleRangeMax(); unsigned getVScaleRangeMin(); Since that would simplify some of the queries to

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, bsmith, paulwalker-arm. Herald added subscribers: ctetreau, dexonsmith, dang, jdoerfert, hiraditya. c-rhodes requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The