[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Oh, OK. If this is not the direction the community want, we might not go on this direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113391/new/ https://reviews.llvm.org/D113391

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. The ideal situation here would be to have a single semantic model that is a superset of the various combinations of behaviors we want. Further entrenching Clang modules and C++20

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

Bigcheese added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:3 + "directory" : "DIR", + "command" : "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

dblaikie added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:3 + "directory" : "DIR", + "command" : "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:162-163 "'%0': unable to use module files with this tool">; +def err_drv_clang_module_cxx_module_conflicts : Error < + "Unable to use clang module and c++20 module at the same

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:3 + "directory" : "DIR", + "command" : "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu updated this revision to Diff 385765. ChuanqiXu added a reviewer: jansvoboda11. ChuanqiXu added a comment. Undo unnecessary style change in *.json files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113391/new/

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

MyDeveloperDay added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3445-3447 - // -fmodules enables the use of precompiled modules (off by default). - // Users can pass -fno-cxx-modules to turn off modules support for - // C++/Objective-C++ programs.

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added a comment. In D113391#3115410 , @tschuett wrote: > It would enforce that there is exactly one module mode live. Yeah. But my consideration is that it would enforce another variable and it couldn't eliminate the two existing variables.

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu updated this revision to Diff 385680. ChuanqiXu added a comment. Herald added subscribers: carlosgalvezp, kbarton, nemanjai. Herald added a project: clang-tools-extra. Update part in clang-tools-extra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

tschuett added a comment. It would enforce that there is exactly module mode live. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113391/new/ https://reviews.llvm.org/D113391 ___ cfe-commits mailing list

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added a comment. In D113391#3115080 , @tschuett wrote: > This sounds like an enum. > > enum class ModuleKind { > C++20, > Clang, > Unsupported > } In fact, there is another value `ModuleTS`. But it looks not bad. And the variable

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu updated this revision to Diff 385440. ChuanqiXu added reviewers: aaron.ballman, rsmith, urnathan, dblaikie. ChuanqiXu set the repository for this revision to rG LLVM Github Monorepo. ChuanqiXu added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github