[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ea0c4e7234: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse (authored by sammccall). Changed prior to commit:

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, this looks good (sorry, I missed this.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall added a comment. Anything left to do here? I think it would be nice to get this into 14 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752 ___

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall updated this revision to Diff 396662. sammccall marked an inline comment as done. sammccall added a comment. Add constant-evaluation for broken switches, and a bunch of evaluation tests. Address other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall marked 6 inline comments as done. sammccall added a comment. In D113752#3188486 , @hokein wrote: > since we're now preserving more invalid code, we should check whether > const-evaluator is cable of handling these newly-added invalid case. >

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

hokein added a comment. since we're now preserving more invalid code, we should check whether const-evaluator is cable of handling these newly-added invalid case. I have played around it, it seems that if, do/while, while cases are already handled well. `switch` case need some work: - the

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall updated this revision to Diff 392776. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752 Files:

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1194 SourceLocation Loc, - Sema::ConditionKind CK, +

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

hokein added a comment. this looks great, some nits and questions. Comment at: clang/lib/Parse/ParseStmt.cpp:1194 SourceLocation Loc, - Sema::ConditionKind CK, +

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall updated this revision to Diff 386797. sammccall added a comment. More conservative in changes to ActOnIfStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752 Files:

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: jdoerfert. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows the body to be parsed. An special-case that would replace a