aaron.ballman added a comment.
FWIW, I think this direction seems reasonable to me. Before semantic analysis,
we can't know the type, it depends on the context that we haven't analyzed yet.
However, I'd ultimately like to hear from @rsmith just in case I am missing
some concerns with the
aaronpuchert added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113837/new/
https://reviews.llvm.org/D113837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaronpuchert added a comment.
Ping @rsmith.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113837/new/
https://reviews.llvm.org/D113837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaronpuchert added a subscriber: JonasToth.
aaronpuchert added a comment.
We could also introduce a separate (placeholder) type for initializer lists and
perhaps also `ParenListExpr` if the dependent type seems misleading to you.
CC @JonasToth for the changes to
aaronpuchert updated this revision to Diff 387054.
aaronpuchert added a comment.
Herald added subscribers: kbarton, nemanjai.
Herald added a project: clang-tools-extra.
Adapt `clang-tidy/checkers/cppcoreguidelines-owning-memory.cpp` and run
clang-format.
Repository:
rG LLVM Github Monorepo
aaronpuchert created this revision.
aaronpuchert added a reviewer: rsmith.
aaronpuchert requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
It was always just a placeholder, but not a particularly good one: the
expression certainly has a value
