[PATCH] D113838: Sema: Don't erroneously reject `void{}`

2023-09-21 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Yeah, we should get this over the line. I'm still not quite sure where to put the check. Reading @rsmith's comment again, SemaInit might perhaps be acceptable for now, except that I should add the additional tests (in case we don't have them already). I think we

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. It looks like this is almost there, can we get it over the line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113838/new/ https://reviews.llvm.org/D113838

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

2022-01-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. This is CWG issue 2351. Please add a corresponding test to `tests/CXX/drs/dr23xx.cpp`. Comment at: clang/lib/Sema/SemaInit.cpp:1311-1319 + } else if (DeclType->isVoidType()) { +// [expr.type.conv]p2: Otherwise, if the type is cv void and the +

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

2021-11-14 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a subscriber: Tyker. aaronpuchert added a comment. CC @Tyker for the changes to `SemaCXX/attr-annotate.cpp`. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5848-5849 def err_illegal_initializer_type : Error<"illegal initializer type %0">; +def

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

2021-11-13 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is explicitly allowed via [expr.type.conv], if the initialization list is empty. Repository: