[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e2aecd759dc: [clang][dataflow] Add base types for building dataflow analyses (authored by sgatev, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev added a comment. Thanks Gábor and Dmitri! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: xazax.hun

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 390034. sgatev added a comment. Minor tweaks to documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 390029. sgatev marked 3 inline comments as done. sgatev added a comment. Replace "Dynamic" with "TypeErased" in the names of types and their members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks, it looks good to me. Most of my comments are just brainstorming, exploring alternative ideas. Feel free to ignore some/all of them. Comment at:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: xazax.hun wrote: > Does the

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389774. sgatev added a comment. Rename Environment.h to DataflowEnvironment.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389773. sgatev added a comment. Put typed and type-erased interfaces in separate files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389522. sgatev marked an inline comment as done. sgatev added a comment. Document the role of the "Dynamic" suffix in the name of DataflowAnalysisDynamic and its members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389189. sgatev marked an inline comment as done. sgatev added a comment. Add a note about asserting the requirements of the CFG object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389166. sgatev added a comment. Remove unnecessary constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: Does the `Dynamic` in the

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388490. sgatev added a comment. Add using namespace declarations in the cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysis.cpp:21-22 + +namespace clang { +namespace dataflow { + It's more common in .cpp files to use using declarations instead: ``` using clang; using dataflow; ```

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388469. sgatev added a comment. Use triple slash at the start of declaration comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388465. sgatev added a comment. Fix ifndefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev created this revision. sgatev added reviewers: ymandel, NoQ, xazax.hun, gribozavr. Herald added subscribers: rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A