[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

2021-11-22 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 388816. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114287/new/ https://reviews.llvm.org/D114287 Files:

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

2021-11-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the fix! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:108 + // Some expressions might be not resolved yet due to ADL: conservatively mark +

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

2021-11-19 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG