Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-27 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 5. xazax.hun added a comment. - Updated to latest trunk. - Added a new field to the event with documentation. - Rebased the patch on the top of nullability checker. - Added covered cases to the nullability checker tests. http://reviews.llvm.org/D11433

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-27 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! http://reviews.llvm.org/D11433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-27 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246182: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D11433?vs=5id=33344#toc Repository: rL

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-17 Thread Anna Zaks via cfe-commits
zaks.anna requested changes to this revision. zaks.anna added a comment. This revision now requires changes to proceed. I believe we saw a regression in diagnostics with this modification. Gabor, do you recall what it was? http://reviews.llvm.org/D11433

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-17 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. The problem here is that, this checker can emit a warning for two cases: 1, Null was bound to a reference which should be reported as a dereference 2, Null was passed to parameter that should be non-null (marked by the attribute, not the qualifier) which should be