Lucas created this revision.
Lucas requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D114839
Files:
clang/lib/Sema/SemaExpr.cpp
Index: clang/lib/Sema/SemaExpr.cpp
===================================================================
--- clang/lib/Sema/SemaExpr.cpp
+++ clang/lib/Sema/SemaExpr.cpp
@@ -15902,10 +15902,9 @@
// If the types are still not compatible, we need to test whether the
// promoted type and the underlying type are the same except for
- // signedness except for boolean. Ask the AST for the correctly
corresponding
- // type and see if that's compatible.
- if (!PromoteType.isNull() &&
- !UnderlyingType->isBooleanType() &&
+ // signedness except for boolean. Ask the AST for the correctly
+ // corresponding type and see if that's compatible.
+ if (!PromoteType.isNull() && !UnderlyingType->isBooleanType() &&
PromoteType->isUnsignedIntegerType() !=
UnderlyingType->isUnsignedIntegerType()) {
UnderlyingType =
Index: clang/lib/Sema/SemaExpr.cpp
===================================================================
--- clang/lib/Sema/SemaExpr.cpp
+++ clang/lib/Sema/SemaExpr.cpp
@@ -15902,10 +15902,9 @@
// If the types are still not compatible, we need to test whether the
// promoted type and the underlying type are the same except for
- // signedness except for boolean. Ask the AST for the correctly corresponding
- // type and see if that's compatible.
- if (!PromoteType.isNull() &&
- !UnderlyingType->isBooleanType() &&
+ // signedness except for boolean. Ask the AST for the correctly
+ // corresponding type and see if that's compatible.
+ if (!PromoteType.isNull() && !UnderlyingType->isBooleanType() &&
PromoteType->isUnsignedIntegerType() !=
UnderlyingType->isUnsignedIntegerType()) {
UnderlyingType =
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
