[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

2021-12-02 Thread Vy Nguyen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaba8f320cc13: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

2021-12-02 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

2021-12-02 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 391472. oontvoo added a comment. doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

2021-12-02 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 391451. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

2021-12-02 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo created this revision. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. oontvoo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Using XCTAssertEqual on NSString* objects are almost always wrong.