This revision was automatically updated to reflect the committed changes.
Closed by commit rGaba8f320cc13: [clang-tidy][objc] Finds and fixes improper
usages of XCTAssertEquals and… (authored by oontvoo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
oontvoo added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114975/new/
https://reviews.llvm.org/D114975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
oontvoo updated this revision to Diff 391472.
oontvoo added a comment.
doc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114975/new/
https://reviews.llvm.org/D114975
Files:
clang-tools-extra/clang-tidy/objc/AssertEquals.cpp
oontvoo updated this revision to Diff 391451.
oontvoo added a comment.
updated diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114975/new/
https://reviews.llvm.org/D114975
Files:
clang-tools-extra/clang-tidy/objc/AssertEquals.cpp
oontvoo created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun, mgorny.
oontvoo requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Using XCTAssertEqual on NSString* objects are almost always wrong.