[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e29da875ca9: Add support for return values in bugprone-stringview-nullptr (authored by CJ-Johnson). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:263 + auto HandleConstructorInvocation = + makeRule(cxxConstructExpr(hasAnyArgument(ignoringImpCasts( +

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:263 + auto HandleConstructorInvocation = + makeRule(cxxConstructExpr(hasAnyArgument(ignoringImpCasts( +

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399436. CJ-Johnson marked an inline comment as done. CJ-Johnson added a comment. Add code comment about the choice of hasAnyArgument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Bravo! This is an impressively thorough job. Thanks for pushing through to completion! Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:263 +

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399376. CJ-Johnson added a comment. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399139. CJ-Johnson added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399135. CJ-Johnson added a comment. Rebase on head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files:

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399134. CJ-Johnson edited the summary of this revision. CJ-Johnson added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files: