This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0cf7e61a42c7: [clang][HeaderSearch] Support framework
includes in suggestPath... (authored by dgoldman).
Changed prior to commit:
sammccall added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:1955
+ bool IsPrivateHeader;
+ SmallString<128> FrameworkName, IncludeSpelling;
+ if (BestPrefixIsFramework &&
sammccall wrote:
> nit: I don't think these strings need to be so big,
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Lex/HeaderSearch.cpp:1955
+ bool IsPrivateHeader;
+ SmallString<128> FrameworkName, IncludeSpelling;
+ if (BestPrefixIsFramework &&
dgoldman updated this revision to Diff 398178.
dgoldman added a comment.
Don't suggest umbrella headers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115183/new/
https://reviews.llvm.org/D115183
Files:
clang/include/clang/Lex/HeaderSearch.h
dgoldman updated this revision to Diff 397882.
dgoldman added a comment.
Improve double-quotes.m test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115183/new/
https://reviews.llvm.org/D115183
Files:
clang/include/clang/Lex/HeaderSearch.h
sammccall added a comment.
Thanks, test seems sensible.
I remain unconvinced that the umbrella stuff belongs here.
Maybe pull it out of this patch and send it separately if you want to discuss
further, or get more opinions?
Comment at: clang/lib/Lex/HeaderSearch.cpp:1962
+
dgoldman added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:782
if (IsIncludeeInFramework) {
- NewInclude += ToFramework.str().drop_back(10); // drop .framework
- NewInclude += "/";
+ NewInclude += ToIncludeSpelling;
+ NewInclude += ">";
dgoldman updated this revision to Diff 397733.
dgoldman marked 4 inline comments as done.
dgoldman added a comment.
Herald added a subscriber: ormris.
Fixes for review - update test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115183/new/
sammccall added a comment.
This looks pretty nice to me, but I'm not convinced it's a good idea to include
the umbrella header heuristic.
Comment at: clang/lib/Lex/HeaderSearch.cpp:782
if (IsIncludeeInFramework) {
- NewInclude += ToFramework.str().drop_back(10); //
dgoldman updated this revision to Diff 392477.
dgoldman added a comment.
Add HeaderSearch tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115183/new/
https://reviews.llvm.org/D115183
Files:
clang/include/clang/Lex/HeaderSearch.h
dgoldman updated this revision to Diff 392180.
dgoldman added a comment.
Use consistent IsSystem detection
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115183/new/
https://reviews.llvm.org/D115183
Files:
clang/lib/Lex/HeaderSearch.cpp
Index:
dgoldman updated this revision to Diff 392176.
dgoldman added a comment.
Fix IncludeSpelling issue
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115183/new/
https://reviews.llvm.org/D115183
Files:
clang/lib/Lex/HeaderSearch.cpp
Index:
dgoldman created this revision.
dgoldman requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Clang will now search through the framework includes to identify
the framework include path to a file, and then suggest a framework
style include
13 matches
Mail list logo
