[PATCH] D115231: [Clang] Add __builtin_reduce_xor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb55ea2fbc0a0: [Clang] Add __builtin_reduce_xor (authored by junaire, committed by fhahn). Changed prior to commit:

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 395791. junaire added a comment. - rebase to main. - rename `PrepareBuiltinReduceMathOneArg` to `prepareBuiltinReduceMathOneArgCall`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added a comment. In D115231#3197112 , @junaire wrote: > Thanks for accepting this patch! I would appreciate it if someone is willing > to commit this for me since I don't have commit access ;D > > You can use: > Jun Zhang > j...@junz.org It

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire added a comment. Thanks for accepting this patch! I would appreciate it if someone is willing to commit this for me since I don't have commit access ;D You can use: Jun Zhang j...@junz.org Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn accepted this revision. fhahn added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 ___ cfe-commits mailing list

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

RKSimon added a comment. In D115231#3194439 , @junaire wrote: > In D115231#3194372 , @RKSimon wrote: > >> Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well >> in the same patch since

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 394697. junaire added a comment. Rename SemaBuiltinReduceMathPreCheck to PrepareBuiltinReduceMathOneArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files:

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Please wait a day or two before landing in case other reviewers have concerns they haven't had the chance to raise yet. Comment at:

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 394563. junaire added a comment. Explicitly speak out types for Arg, but don't repeat the vector type name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files:

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2115 + +const auto *Arg = TheCall->getArg(0); +const VectorType *TyA = Arg->getType()->getAs(); Please spell out the type here (same below). Comment at:

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire added a comment. In D115231#3194372 , @RKSimon wrote: > Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well > in the same patch since they are very similar? Hi, thanks for take a look at this. Yes, you're right. The

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

RKSimon added a comment. Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well in the same patch since they are very similar? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 393142. junaire added a comment. Fix wrong code logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 393057. junaire added a comment. Fix failing CI by running: arc diff `git merge-base HEAD origin` --update D115231 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2116 + + // __builtin_reduce_xor restricts the element type to vector of integers type + // only. nit: the element type will be restricted to `int`, so maybe say something like `only

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 392785. junaire added a comment. - Add extra type check to the vector elements. - Add comment about type restriction. - polish tests a little bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files:

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2113 + case Builtin::BI__builtin_reduce_xor: if (SemaBuiltinReduceMath(TheCall)) return ExprError(); I think `reduce_xor` is only specified for integer types, so I think we

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire created this revision. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements __builtin_reduce_xor as specified in D111529 . Repository: rG LLVM Github Monorepo