Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

2015-08-26 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 33235. EricWF added a comment. Address @mclow.lists note about consistency. http://reviews.llvm.org/D11553 Files: include/__functional_base include/__functional_base_03 include/functional

Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

2015-08-26 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/__functional_base:521 @@ +520,3 @@ +operator() (_ArgTypes... __args) const { +return __invoke(get(), _VSTD::forward_ArgTypes(__args)...); +} I know you didn't change this, but how did we get

Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

2015-08-26 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Ok, I think this is good to go. Thanks, Eric. http://reviews.llvm.org/D11553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

2015-08-26 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. So far, this looks good. I'm going to apply it locally and futz with it. Comment at: include/__functional_base_03:30 @@ +29,3 @@ +typedef _Ret _Bullet2; +typedef _Ret type; +}; Let's be consistent. :-) typedef _Bullet2