FreddyYe abandoned this revision.
FreddyYe added a comment.
agree with @pengfei . sorry for noise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115611/new/
https://reviews.llvm.org/D115611
___
pengfei requested changes to this revision.
pengfei added a comment.
This revision now requires changes to proceed.
I would suggest we drop the change. Sorry for my fickleness :(
Comment at: clang/lib/Headers/avx512bf16intrin.h:32
/// \param __A
///A bfloat data.
///
skan accepted this revision.
skan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115611/new/
https://reviews.llvm.org/D115611
___
FreddyYe updated this revision to Diff 394137.
FreddyYe added a comment.
clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115611/new/
https://reviews.llvm.org/D115611
Files:
clang/lib/Headers/avx512bf16intrin.h
FreddyYe updated this revision to Diff 394134.
FreddyYe added a comment.
changed into `unsigned short`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115611/new/
https://reviews.llvm.org/D115611
Files:
clang/lib/Headers/avx512bf16intrin.h
craig.topper added inline comments.
Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416
///and fraction field is truncated to 7 bits.
-static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) {
+static __inline__ short __DEFAULT_FN_ATTRS128
pengfei added inline comments.
Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416
///and fraction field is truncated to 7 bits.
-static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) {
+static __inline__ short __DEFAULT_FN_ATTRS128
pengfei added inline comments.
Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416
///and fraction field is truncated to 7 bits.
-static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) {
+static __inline__ short __DEFAULT_FN_ATTRS128
FreddyYe added inline comments.
Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416
///and fraction field is truncated to 7 bits.
-static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) {
+static __inline__ short __DEFAULT_FN_ATTRS128
craig.topper added inline comments.
Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416
///and fraction field is truncated to 7 bits.
-static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) {
+static __inline__ short __DEFAULT_FN_ATTRS128
FreddyYe created this revision.
Herald added a subscriber: pengfei.
FreddyYe requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The name `__bfloat` may mislead its real type is bfloat16, but in
fact it's not.
Repository:
rG LLVM Github
11 matches
Mail list logo