[PATCH] D116059: [Clang][CFG] check children statements of asm goto

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a604fdbcd5f: [Clang][CFG] check children statements of asm goto (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

jyu2 accepted this revision. jyu2 added a comment. Looks good to me. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 ___ cfe-commits mailing list

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nathanchance added a comment. The two false positive warnings in the kernel are fixed with this patch and there were no new warnings introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/test/Analysis/uninit-asm-goto.cpp:84 + +int test8() { +int x = 0; // expected-warning {{variable 'x' is used uninitialized whenever its declaration is reached}}

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

efriedma accepted this revision. efriedma added a comment. LGTM Comment at: clang/test/Analysis/uninit-asm-goto.cpp:84 + +int test8() { +int x = 0; // expected-warning {{variable 'x' is used uninitialized whenever its declaration is reached}} Looks like

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers updated this revision to Diff 397983. nickdesaulniers added a comment. This revision is now accepted and ready to land. - MOAR TESTS RAWR!!1one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. will add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 ___

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers updated this revision to Diff 397965. nickdesaulniers added a comment. This revision is now accepted and ready to land. - add previously red -Warray-bounds test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

efriedma added a comment. Yes, messed up the warning flag. Did some brief experiments on trunk; I'd like to see the following two testcases as regression tests: int a(int z) { int x; if (z) asm goto ("":"=r"(x):::A1,A2); return 0; A1: A2: return x;

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers added a comment. In D116059#3225862 , @efriedma wrote: > Do we have testcases for how -Wuninitialized/-Wmaybe-uninitialized interact > with asm goto? We have tests for `-Wuninitialized`; clang/test/Analysis/uninit-asm-goto.cpp (D71314

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

efriedma added a comment. Do we have testcases for how -Wuninitialized/-Wmaybe-uninitialized interact with asm goto? If not, can you add them? Also, an explicit test for -Warray-bounds or whatever would be nice, although I guess the CFG tests sort of cover that. Repository: rG LLVM Github

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers updated this revision to Diff 397728. nickdesaulniers added a comment. - don't bother checking if a Val is Initialized Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 Files:

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] = MayUninitialized;

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] =

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

efriedma added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] = MayUninitialized;

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers updated this revision to Diff 395539. nickdesaulniers added a comment. - VisitChildren rather than VisitStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 Files:

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:3359 + + return VisitStmt(G, asc); } I think this should actually be `return VisitChildren(G);`; it produces a simpler CFG with the

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, jyknight, jyu2, efriedma. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When performing CFG based analyses, don't forget to check the child