aprantl added a comment.
How does this relate to the code in `llvm/utils/lldbDataFormatters.py` and
should it be added there instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116113/new/
https://reviews.llvm.org/D116113
labath added a comment.
Seems fairly straight-forward (and definitely useful). Just a couple of quick
comments.
Comment at: clang/utils/ClangDataFormat.py:28-35
+debugger.HandleCommand("type summary add -F
ClangDataFormat.Optional_summary -x 'llvm::Optional<.*>'")
+
wallace added a comment.
thanks for doing this. Just a few minor comments and i think this is good to go
Comment at: clang/utils/ClangDataFormat.py:215-218
+if self.hasVal:
+result = self.value.GetIndexOfChildWithName(name)
+return None if
clayborg created this revision.
clayborg added reviewers: labath, teemperor, aprantl.
Herald added subscribers: usaxena95, arphaman.
clayborg requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This allows us to see the contents of the