[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28d2977ff236: [-fms-extensions] Make some exception specification warnings/errors compatible… (authored by akhuang). Repository: rG LLVM Github

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116256/new/ https://reviews.llvm.org/D116256

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang updated this revision to Diff 397930. akhuang marked an inline comment as done. akhuang added a comment. Add std=c++17 to the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116256/new/ https://reviews.llvm.org/D116256 Files:

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

thakis added inline comments. Comment at: clang/test/SemaCXX/MicrosoftCompatibility.cpp:4 // RUN: %clang_cc1 %s -triple i686-pc-win32 -fsyntax-only -std=c++11 -Wmicrosoft -verify -fms-compatibility -fexceptions -fcxx-exceptions -fms-compatibility-version=19.00 // RUN:

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang added a comment. In D116256#3215801 , @thakis wrote: > Thanks for the patch! This looks roughly right to me. > > Maybe the list of ESTs that are allowed to be mismatched should be opt-in > instead of opt-out? (i.e. instead of checking for "not

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang updated this revision to Diff 397760. akhuang marked an inline comment as done. akhuang added a comment. Fix warning behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116256/new/ https://reviews.llvm.org/D116256 Files:

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

thakis added a comment. Thanks for the patch! This looks roughly right to me. Maybe the list of ESTs that are allowed to be mismatched should be opt-in instead of opt-out? (i.e. instead of checking for "not EST_BasicNoexcept / EST_DependentNoexcept", check for EST_NoThrow (I think?) Not sure

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang created this revision. akhuang added reviewers: hans, thakis. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make clang-cl error when a function definition is missing 'noexcept', and succeed without warnings when missing