[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

2022-01-07 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan added a comment. In D116272#3228427 , @tstellar wrote: > We may have time to fit it in to the release, but no guarantees. Can you > file an issue for this? That would be great. I filed an issue:

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

2022-01-07 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. We may have time to fit it in to the release, but no guarantees. Can you file an issue for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116272/new/ https://reviews.llvm.org/D116272

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

2022-01-07 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan added a comment. Thank you @aaron.ballman, I will try to get this patch into the next 13.0.x release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116272/new/ https://reviews.llvm.org/D116272

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

2022-01-07 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc033f0d9b1c7: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument (authored by egorzhdan, committed by jansvoboda11).

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

2022-01-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a subscriber: tstellar. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! I think this would also be a reasonable candidate for a 13.0.X release, in case you wanted to file an

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

2021-12-24 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan created this revision. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a compiler crash that was introduced in https://reviews.llvm.org/D103611: `Sema::BuildVAArgExpr` attempted to retrieve a