[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added a comment. @nikic I have tried to address your concerns in https://reviews.llvm.org/D118792 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/new/ https://reviews.llvm.org/D116492

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added a comment. In D116492#3290087 , @nikic wrote: > Would it be possible to share a complete new-style cmake invocation that is > supposed to work? Our standalone LLD package in Nixpkgs works, but I see now we have been passing

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

nikic added a comment. Would it be possible to share a complete new-style cmake invocation that is supposed to work? If I only point LLVM_DIR to the cmake directory, then LLVM_MAIN_SRC_DIR ends up being empty (it is set to MAIN_SRC_DIR, which, as far as I can tell, is only initialized in the

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

nikic added inline comments. Comment at: lld/CMakeLists.txt:14 + set(LLVM_CONFIG_OUTPUT) + if(LLVM_CONFIG) +set (LLVM_CONFIG_FOUND 1) Is it intentional that lld now requires you to set LLVM_CONFIG instead of LLVM_CONFIG_PATH? Based on the deprecation, I

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1da5f3c2d65: [lld] Deprecate using llvm-config to detect llvm installation (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/new/ https://reviews.llvm.org/D116492 ___

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added inline comments. Comment at: lld/CMakeLists.txt:17 - execute_process(COMMAND "${LLVM_CONFIG_PATH}" - "--obj-root" - "--includedir" `--obj-root` is the same thing as `--prefix`, so this is in

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" Ericson2314 wrote: > beanz wrote: > > Ericson2314 wrote: > > >

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" beanz wrote: > Ericson2314 wrote: > > beanz wrote: > > > I assume

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 updated this revision to Diff 397100. Ericson2314 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Split out Clang changes into separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

beanz added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" Ericson2314 wrote: > beanz wrote: > > I assume these are re-arranged to match what you're doing in lld. Is that > >

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" beanz wrote: > I assume these are re-arranged to match what you're doing in lld. Is that > correct? > >

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

beanz added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" I assume these are re-arranged to match what you're doing in lld. Is that correct? Generally it is preferred to do

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added a comment. Note this is a first draft, I need to go test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/new/ https://reviews.llvm.org/D116492 ___ cfe-commits mailing list

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 created this revision. Ericson2314 added a reviewer: tstellar. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is continuing in the path of D51714