[PATCH] D116521: [CMake] Factor out config prefix finding logic

2022-01-17 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:209 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" + "${LLVM_COMMON_CMAKE_UTILS}/Modules" ) Ericson2314 wrote: > sebastian-ne wrote: > > Hi,

[PATCH] D116521: [CMake] Factor out config prefix finding logic

2022-01-17 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:209 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" + "${LLVM_COMMON_CMAKE_UTILS}/Modules" ) sebastian-ne wrote: > Hi, adding this module path overwrites the `llvm_check_linker_flag` from >

[PATCH] D116521: [CMake] Factor out config prefix finding logic

2022-01-17 Thread Sebastian Neubauer via Phabricator via cfe-commits
sebastian-ne added inline comments. Comment at: llvm/CMakeLists.txt:209 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" + "${LLVM_COMMON_CMAKE_UTILS}/Modules" ) Hi, adding this module path overwrites the `llvm_check_linker_flag` from

[PATCH] D116521: [CMake] Factor out config prefix finding logic

2022-01-07 Thread John Ericson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44e336577510: [CMake] Factor out config prefix finding logic (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116521: [CMake] Factor out config prefix finding logic

2022-01-07 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116521/new/ https://reviews.llvm.org/D116521 ___ cfe-commits mailing list

[PATCH] D116521: [CMake] Factor out config prefix finding logic

2022-01-07 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Seems like a cleanup to me, and consistent with D116524 . Soft-accept, but only if D116524 is accepted first.

[PATCH] D116521: [CMake] Factor out config prefix finding logic

2022-01-03 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 397116. Ericson2314 added a comment. Oops, forgot some includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116521/new/ https://reviews.llvm.org/D116521 Files: clang/CMakeLists.txt