[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

hans added a comment. In D116527#3479509 , @curdeius wrote: > Feel free to revert and add a regression test please. I'll take a look. Since this patch landed a couple of months back, I don't think we need to rush to revert it. Repository: rG LLVM

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. Feel free to revert and add a regression test please. I'll take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 ___

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

hans added a comment. Herald added a project: All. This seems to have caused a strange indentation problem, see https://github.com/llvm/llvm-project/issues/55161 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5109737c924d: [clang-format] Fix indentation for array variables with alignment of… (authored by curdeius). Repository: rG LLVM Github Monorepo

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius updated this revision to Diff 397265. curdeius added a comment. Reverted test changes. Checking for identifier before brace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 Files:

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

MyDeveloperDay added a comment. Could we resolve this with just // Continued braced list. if (Changes[ScopeStart - 2].Tok->isNot(tok::identifier) && Changes[ScopeStart - 1].Tok->is(tok::l_brace) && Changes[i].Tok->isNot(tok::r_brace)) return true; Repository: rG LLVM

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

MyDeveloperDay added a comment. This is born out by setting ContinuationIndentWidth: 8 int i = 0; float i2 = 0; auto v = type{ i = 1, // (i = 2), // i = 3// }; So maybe the original test is correct.. Repository: rG LLVM Github Monorepo

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

owenpan added a comment. Unless the test cases are wrong, they should not be changed. The original test case looked correct to me as it was doing a continuation indent between `type{` and `}`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. In D116527#3217211 , @MyDeveloperDay wrote: > The fix looks ok, butr I don't understand the cause of the side effect? is it > explicitly aligning to the v of `auto v`? It's adding two spaces inside the `auto v = ...`,

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

MyDeveloperDay added a comment. The fix looks ok, butr I don't understand the cause of the side effect? is it explicitly aligning to the v of `auto v`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. I know I changed existing tests. I'm not sure what we really want here. If you have ideas, I'm open to suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52914. Repository: rG