[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876b5ea96bf5: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective… (authored by saiislam). Repository: rG LLVM Github

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks for the adjustment. Hope you are happy with the result. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398897. saiislam added a comment. 1. Used a common diagnostic warning `warn_unknown_declare_variant_isa_trait` for ParseOpenMP and SemaOpenMP for decalre variant and metadirectives. 2. Split lit codegen tests into two files, one requiring amdgpu-registered

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext,

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext,

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext,

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398614. saiislam added a comment. Fixed the lit test failing in pre-check build bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/ https://reviews.llvm.org/D116549 Files:

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398179. saiislam marked an inline comment as done. saiislam added a comment. Added diagnostic remarks for when ISA trait is not selected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext,

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 397912. saiislam added a comment. Herald added a subscriber: jvesely. Added target specific tests for ISA traits, for CPU as well as GPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam added a comment. In D116549#3218281 , @jdoerfert wrote: > Can you make the test check for the diagnose message? Also, do we have a test > to verify an isa trait is properly handled? I don't see a point in adding a diagnostic message when a

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added a comment. Can you make the test check for the diagnose message? Also, do we have a test to verify an isa trait is properly handled? Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam created this revision. saiislam added reviewers: jdoerfert, alokmishra.besu, cchen, JonChesterfield. Herald added subscribers: guansong, yaxunl. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Passing any feature