[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

2022-01-28 Thread Alex Tsao via Phabricator via cfe-commits
alextsao1999 marked 2 inline comments as done. alextsao1999 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3209 +} else + D.Diag(clang::diag::err_invalid_ssp_buffer_size); } compnerd wrote: > Please consistently

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

2022-01-08 Thread Alex via Phabricator via cfe-commits
alextsao1999 updated this revision to Diff 398354. alextsao1999 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116722/new/ https://reviews.llvm.org/D116722 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

2022-01-07 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3204 if (StackProtectorLevel) { -CmdArgs.push_back("-stack-protector-buffer-size"); -// FIXME: Verify the argument is a valid integer. -

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

2022-01-05 Thread Alex via Phabricator via cfe-commits
alextsao1999 created this revision. alextsao1999 added a reviewer: compnerd. alextsao1999 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds to verify whether the ssp buffer size is a legal integer and a new diagnostic driver