This revision was automatically updated to reflect the committed changes.
Closed by commit rG140a6b1e5c68: [clang][OpenMP5.1] Initial parsing/sema for
indirect clause (authored by jyu2).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116764/new/
jyu2 updated this revision to Diff 398249.
jyu2 added a comment.
Fix format problem.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116764/new/
https://reviews.llvm.org/D116764
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/DiagnosticParseKinds.td
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1844
+ if (!IsDeviceTypeClause && !IsIndirectClause &&
+ DTCI.Kind == OMPD_begin_declare_target) {
jyu2 added a comment.
Thanks Alexey for the code review.
Comment at: clang/include/clang/Sema/Sema.h:10338
+Expr *IndirectExpr = nullptr;
+bool IsIndirect = false;
+
ABataev wrote:
> Can you use `Optional` instead of `Expr *` and `bool`?
Good to know.
jyu2 updated this revision to Diff 398043.
jyu2 added a comment.
Address Alexey's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116764/new/
https://reviews.llvm.org/D116764
Files:
clang/include/clang/Basic/Attr.td
ABataev added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:10338
+Expr *IndirectExpr = nullptr;
+bool IsIndirect = false;
+
Can you use `Optional` instead of `Expr *` and `bool`?
Comment at:
jyu2 created this revision.
jyu2 added reviewers: ABataev, mikerice, jdoerfert.
jyu2 added a project: clang.
Herald added subscribers: guansong, yaxunl.
Herald added a reviewer: aaron.ballman.
Herald added a project: Flang.
jyu2 requested review of this revision.
Herald added subscribers:
