[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

jrtc27 added a comment. Ping? I'd really like to get this fixed in 14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

jrtc27 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

aaron.ballman added a comment. In D116774#3227280 , @jrtc27 wrote: > The fact that va_list is in the std namespace does leak out into > __builtin_dump_struct, possibly the odd other place, and of course to > external AST consumers. It can also leak

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

pcc added a comment. I'm not aware of any of those places causing an actual problem though? The AST isn't a stable interface, and __builtin_dump_struct is for debugging purposes only. I would expect debug info consumers to be able to handle __va_list in the global namespace as this is the

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

jrtc27 added a comment. The fact that va_list is in the std namespace does leak out into __builtin_dump_struct, possibly the odd other place, and of course to AST consumers. I think it'd make sense to keep ASTContext as putting it in the std namespace for C++ (like it does for Arm, and used

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

pcc created this revision. pcc added reviewers: rsmith, eugenis, jrtc27. Herald added a subscriber: kristof.beyls. pcc requested review of this revision. Herald added a project: clang. In post-commit feedback on D104830 Jessica Clarke pointed out that