[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

hans added a comment. In D116835#3228296 , @arlosi wrote: > I submitted a change last year to hook up the /ZH option, but it was never > completed. https://reviews.llvm.org/D98438 I just put some comments on that. I'm happy to provide review if you

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

rnk added a comment. I think it's worth taking the time to hook up /ZH. Sorry we missed the patch last March. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116835/new/ https://reviews.llvm.org/D116835

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

arlosi added a comment. I submitted a change last year to hook up the /ZH option, but it was never completed. https://reviews.llvm.org/D98438 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116835/new/ https://reviews.llvm.org/D116835

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

hans added a comment. After sending this, I realized we should probably have a test to make sure it gets all the way into the .o and .pdb files correctly... And, maybe we should hook up the /ZH flag? (https://docs.microsoft.com/en-us/cpp/build/reference/zh?view=msvc-170=true still says MD5 is

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

hans created this revision. hans added reviewers: thakis, rnk, arlosi. Herald added subscribers: dexonsmith, hiraditya. hans requested review of this revision. Herald added projects: clang, LLVM. >From the VS2022 release notes, it sounds like newer MSVC versions are using >SHA256 for these