This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG98ab43a1d209: [HIP] Fix device only linking for -fgpu-rdc
(authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github
yaxunl updated this revision to Diff 398662.
yaxunl added a comment.
avoid clearing AL
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116840/new/
https://reviews.llvm.org/D116840
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/hip-phases.hip
yaxunl added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3173
+ AssociatedOffloadKind);
+AL.clear();
+// Offload the host object to the host linker.
tra wrote:
> Doing `clear()` in a function intended to append looks
tra added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3173
+ AssociatedOffloadKind);
+AL.clear();
+// Offload the host object to the host linker.
Doing `clear()` in a function intended to append looks suspicious.
yaxunl created this revision.
yaxunl added a reviewer: tra.
yaxunl requested review of this revision.
Currently when -fgpu-rdc is specified, HIP toolchain always does host linking
even
if --cuda-device-only is specified.
This patch fixes that. Only device linking is performed when
