[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

steakhal added inline comments. Comment at: clang/test/Analysis/symbol-simplification-mem-region-to-int-cast.cpp:23 + clang_analyzer_eval(p == 0);// expected-warning{{TRUE}} + clang_analyzer_eval(p_as_integer == 0); // expected-warning{{UNKNOWN}} +

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

steakhal added a comment. Looks correct to me. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:110-112 + SVal simplifySymbolCast(SymbolRef SE, QualType CastTy); + You don't need to have gap between these two. They belong in

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong updated this revision to Diff 435152. martong added a comment. - Rebase to llvm/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117229/new/ https://reviews.llvm.org/D117229 Files:

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117229/new/ https://reviews.llvm.org/D117229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong updated this revision to Diff 427621. martong marked 2 inline comments as done. martong added a comment. - add new assert for canonical type - remove superflous assert about makeSymbolVal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong marked 3 inline comments as done. martong added a comment. Herald added a project: All. Thanks for the review Denys, and sorry for the long delay with the update. I hope that this patch is going to complement nicely the rest of the cast patches. Comment at:

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1088 } + +SVal clang::ento::SValBuilder::simplifySymbolCast(nonloc::SymbolVal V, ASDenysPetrov wrote: > Notify the user about the contract. Mistake. `CastTy`, not

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1088 } + +SVal clang::ento::SValBuilder::simplifySymbolCast(nonloc::SymbolVal V, Notify the user about the contract. Comment at:

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1022 +SVal clang::ento::SValBuilder::simplifySymbolCast(SymbolRef SE, + QualType CastTy) { ASDenysPetrov wrote: > And it'd

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong updated this revision to Diff 401274. martong marked an inline comment as done. martong added a comment. - Move the comment hunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117229/new/ https://reviews.llvm.org/D117229 Files:

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1022 +SVal clang::ento::SValBuilder::simplifySymbolCast(SymbolRef SE, + QualType CastTy) { And it'd be great if you

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong created this revision. martong added reviewers: ASDenysPetrov, NoQ, steakhal. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested