[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

2022-09-01 Thread Kevin Athey via Phabricator via cfe-commits
kda updated this revision to Diff 457370. kda added a comment. Herald added a subscriber: Enna1. Herald added a project: All. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622 Files:

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

2022-01-27 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: compiler-rt/test/msan/noundef_analysis.cpp:5 // RUN: FileCheck %s < %t.out -// RUN: %clangxx_msan %s -disable-noundef-analysis -s -fsanitize-memory-param-retval -o %t && not %run %t >%t.out 2>&1 +// RUN: %clangxx_msan %s

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

2022-01-27 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. I recommend to delay this from some time until we sure it's not going to be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

2022-01-18 Thread Kevin Athey via Phabricator via cfe-commits
kda updated this revision to Diff 401028. kda added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. remove "-s" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

2022-01-18 Thread Kevin Athey via Phabricator via cfe-commits
kda created this revision. kda added a reviewer: vitalybuka. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fixing up some comments and removing redundant tests. Repository: rG LLVM Github Monorepo