[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-27 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance abandoned this revision. nathanchance added a comment. As discussed, this is not the right fix for the issue. I have just gone ahead and told the original reporter to use `scan-build` with the `--use-cc=clang` flag to avoid these issues. Repository: rG LLVM Github Monorepo

[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. I'm not really familiar with `scan-build`, we at CodeChecker, we ignore this gcc specific flag explicitly: https://github.com/Ericsson/codechecker/blob/85dd52dc8f4d47fcf26419fcb44de1ff2a58924f/analyzer/codechecker_analyzer/buildlog/log_parser.py#L72 So, IMO we should

[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: steakhal, NoQ, martong, Szelethus. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. Adding some reviewers from the Clang Static Analyzer side of things. In D117717#3256243 , @nathanchance wrote: >

[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-19 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. In D117717#3256293 , @MaskRay wrote: > Assuming scan-build is clang/tools/scan-build, which is in tree and can be > fixed instead. Yes, that is the one. > I am not familiar with it, but from > >> However, this caused

[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Assuming scan-build is clang/tools/scan-build, which is in tree and can be fixed instead. I am not familiar with it, but from > However, this caused issues with scan-build, as GCC is used as the compiler > but clang is invoked after it with all the -f options that GCC

[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-19 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. In D117717#3256180 , @MaskRay wrote: > Clang has a long list of ignored options but most were added during the > catch-up phase when Clang strove to be a competitor compiler. > I think for new ignored options there needs to

[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Clang has a long list of ignored options but most were added during the catch-up phase when Clang strove to be a competitor compiler. I think for new ignored options there needs to be some higher standard. From Debian Code Search

[PATCH] D117717: [clang] Ignore -fconserve-stack

2022-01-19 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance created this revision. nathanchance added reviewers: aaron.ballman, MaskRay, srhines. Herald added a subscriber: dang. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag is used when building the Linux