[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou added a comment. In D119493#3403458 , @efriedma wrote: > Thank Eli for your comment and guidance and sorry to have carelessly neglected your comment for 7 months! > I'm not sure this is the right fix. If we were handling the

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

efriedma added a comment. I'm not sure this is the right fix. If we were handling the pseudo-destructor correctly, I would expect the following to compile successfully: typedef bool Var; constexpr bool foobool() { return (bool().Var::~Var(), false); } CHANGES SINCE LAST ACTION

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou updated this revision to Diff 416636. zhouyizhou edited the summary of this revision. zhouyizhou added reviewers: mizvekov, eli.friedman, EricWF, faisalv. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119493/new/ https://reviews.llvm.org/D119493

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou created this revision. zhouyizhou added reviewers: rsmith, hokein. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In LLVM/Clang Debug build, following code will trigger the assert to fire: typedef int I; void foo() {