[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu updated this revision to Diff 434680. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/ https://reviews.llvm.org/D119646 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Decl.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D119646: [clang] Allow consteval functions in default arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with some small fixes to the release note. Thanks @ChuanqiXu! Comment at: clang/docs/ReleaseNotes.rst:166 type. +- Clang will allow constexpr function in default argument. This fixes + `Issue 48230

[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu updated this revision to Diff 434373. ChuanqiXu added a comment. Add release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/ https://reviews.llvm.org/D119646 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Decl.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu commandeered this revision. ChuanqiXu edited reviewers, added: Izaron; removed: ChuanqiXu. ChuanqiXu added a comment. Given this is close to complete and @Izaron is not active recently, let me take this over. The authority would be remained, of course. Repository: rG LLVM Github

[PATCH] D119646: [clang] Allow consteval functions in default arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well, but please add a release note about the bug fix (and reference the issue it closes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/

[PATCH] D119646: [clang] Allow consteval functions in default arguments

erichkeane accepted this revision. erichkeane added a comment. This seems innocuous enough, and seems to better reflect the intent of the standard, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/

[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu accepted this revision as: ChuanqiXu. ChuanqiXu added a comment. This revision is now accepted and ready to land. This change LGTM and I prefer the change than D74130 since this one is much more comprehensible. Repository: rG LLVM Github Monorepo

[PATCH] D119646: [clang] Allow consteval functions in default arguments

Izaron added a comment. In D119646#3317473 , @cor3ntin wrote: > There is also https://reviews.llvm.org/D74130 which tries to address the same > issue in a very different way. > I don't really understand the different approaches yet. Thanks! I spent

[PATCH] D119646: [clang] Allow consteval functions in default arguments

cor3ntin added a comment. There is also https://reviews.llvm.org/D74130 which tries to address the same issue in a very different way. I don't really understand the different approaches yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119646: [clang] Allow consteval functions in default arguments

erichkeane added inline comments. Comment at: clang/lib/AST/Decl.cpp:2816 if (auto *E = dyn_cast_or_null(Arg)) -return E->getSubExpr(); +if (!isa(E)) + return E->getSubExpr(); So what is happening here? I would still expect us to give the proper

[PATCH] D119646: [clang] Allow consteval functions in default arguments

Izaron created this revision. Izaron added reviewers: aaron.ballman, erichkeane, andreasfertig. Herald added a subscriber: kristof.beyls. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We should not mark a function as "referenced"